Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document and recommend `default_server_name` #8832

Merged
merged 1 commit into from Feb 21, 2019

Conversation

@jryans
Copy link
Member

jryans commented Feb 20, 2019

This the recommended way to define a default server (instead of the existing HS
and IS URL options). It will use .well-known discovery to find the URLs.

See #8763.

This the recommended way to define a default server (instead of the existing HS
and IS URL options). It will use `.well-known` discovery to find the URLs.

See #8763.
@jryans jryans requested a review from vector-im/riot-web Feb 20, 2019
@turt2live turt2live self-assigned this Feb 20, 2019
@turt2live turt2live removed their assignment Feb 20, 2019
@jryans jryans merged commit 62d4bb2 into develop Feb 21, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alexte

This comment has been minimized.

Copy link

alexte commented Mar 28, 2019

neither config.sample.json nor https://riot.im/develop/config.json has default_server_name.
If this is the new default it should be at least in config.sample.json

@jryans

This comment has been minimized.

Copy link
Member Author

jryans commented Mar 29, 2019

neither config.sample.json nor https://riot.im/develop/config.json has default_server_name.
If this is the new default it should be at least in config.sample.json

We're planning some future improvements in this area that may continue to morph the config structure. For config.sample.json, we'll probably rely on a script like this going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.