Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a require alias for the webapp directory #9014

Merged
merged 2 commits into from Mar 1, 2019

Conversation

@dbkr
Copy link
Member

dbkr commented Mar 1, 2019

So languagehandler can pull the languages json from there

matrix-org/matrix-react-sdk#2730

So languagehandler can pull the languages json from there
@dbkr dbkr requested a review from vector-im/riot-web Mar 1, 2019
@dbkr dbkr changed the title Set a resuire alias for the webapp directory Set a require alias for the webapp directory Mar 1, 2019
@@ -157,14 +151,15 @@ module.exports = {

// same goes for js-sdk
"matrix-js-sdk": path.resolve('./node_modules/matrix-js-sdk'),

"Webapp": path.resolve('./webapp'),

This comment has been minimized.

Copy link
@jryans

jryans Mar 1, 2019

Member

Out of curiosity... why capital "W" here? The capital seems a bit out of place, since I don't think any other paths will have them... If you want the name to suggest it's a special keyword, maybe prefix the alias with some token like $webapp?

This comment has been minimized.

Copy link
@dbkr

dbkr Mar 1, 2019

Author Member

Mostly just as it seemed to be a semi-convention with other people who used resolve.alias, to distinguish it from a real npm module which are generally lowercase. I assume $ would work too.

This comment has been minimized.

Copy link
@jryans

jryans Mar 1, 2019

Member

Ah okay, I see that's the convention described in Webpack docs, for example. Well, whichever seems best to you then.

@jryans
jryans approved these changes Mar 1, 2019
Copy link
Member

jryans left a comment

Looks good to me, assuming CI agrees! Seems easier to work with now.

(Thanks for indulging my naming nit... 😁)

@dbkr dbkr merged commit 4a5a735 into release-v1.0.2 Mar 1, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.