Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change olm dependency to normal dep #9068

Merged
merged 3 commits into from Mar 6, 2019

Conversation

@dbkr
Copy link
Member

dbkr commented Mar 6, 2019

It would be nice if it were actually an optional dependency and you
could just not install olm and get a Riot without olm, but you can't:
what you get is a broken Riot, so having it as an optional dep isn't
helping anyone.

Also whatever other package-lock changes npm has decided are
necessary today.

It would be nice if it were actually an optional dependency and you
could just not install olm and get a Riot without olm, but you can't:
what you get is a broken Riot, so having it as an optional dep isn't
helping anyone.

Also whatever other package-lock changes npm has decided are
necessary today.
@dbkr dbkr requested a review from vector-im/riot-web Mar 6, 2019
@jryans jryans self-assigned this Mar 6, 2019
@jryans
jryans approved these changes Mar 6, 2019
Copy link
Member

jryans left a comment

I had been thinking to do this as well. Thanks! 😁

"optionalDependencies": {
"olm": "https://matrix.org/packages/npm/olm/olm-3.1.0-pre1.tgz"
},
"optionalDependencies": {},

This comment has been minimized.

Copy link
@jryans

jryans Mar 6, 2019

Member

Maybe remove the optionalDep key entirely, now that it's empty?

@jryans jryans assigned dbkr and unassigned jryans Mar 6, 2019
@dbkr dbkr merged commit 1b6da01 into develop Mar 6, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.