Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node 8.x from the build matrix #9159

Merged
merged 2 commits into from Mar 13, 2019

Conversation

@turt2live
Copy link
Member

turt2live commented Mar 13, 2019

We don't support Node 8 anymore. Also the build is broken.

We don't support Node 8 anymore. Also the build is broken.
@turt2live turt2live requested a review from vector-im/riot-web Mar 13, 2019
@turt2live turt2live added this to In Review in Workflow Mar 13, 2019
@jryans
jryans approved these changes Mar 13, 2019
Copy link
Member

jryans left a comment

Thanks! 😁

.travis.yml Outdated
@@ -15,8 +15,10 @@ node_js:
# Current status of node versions: https://github.com/nodejs/LTS/
# We don't work with node 6 because it doesn't support package-lock
# files which we need to avoid the broken version of base-x

This comment has been minimized.

Copy link
@jryans

jryans Mar 13, 2019

Member

Maybe remove the historical explanation above? Our supported set is now effectively "LTS or newer", so I don't think we need to say much more to explain it. (Whatever seems best to you though!)

This comment has been minimized.

Copy link
@turt2live

turt2live Mar 13, 2019

Author Member

I have to admit: I didn't actually read any of this. Will remove the explanation

@turt2live turt2live merged commit 1d51507 into develop Mar 13, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Workflow automation moved this from In Review to In Test Mar 13, 2019
@turt2live turt2live deleted the travis/node-8-isnt-real branch Mar 13, 2019
@turt2live turt2live moved this from In Test to Done in Workflow Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.