Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Buildkite for CI #9165

Merged
merged 6 commits into from Mar 15, 2019

Conversation

@turt2live
Copy link
Member

turt2live commented Mar 14, 2019

TODO: Better pipelines (see #9019)

Part of fixing #9164

Partnered with:

@turt2live turt2live force-pushed the travis/buildkite branch from b2874b5 to 363f14e Mar 14, 2019
@turt2live turt2live force-pushed the travis/buildkite branch from 113528a to f6d4c6a Mar 14, 2019
@turt2live

This comment has been minimized.

Copy link
Member Author

turt2live commented Mar 14, 2019

This PR doesn't have status checks yet because for some reason BuildKite isn't sending them (or can't?)

@turt2live turt2live force-pushed the travis/buildkite branch 15 times, most recently from 8439b08 to 0d63181 Mar 14, 2019
@turt2live turt2live force-pushed the travis/buildkite branch from 1b856ec to 1fb8b23 Mar 14, 2019
@turt2live turt2live force-pushed the travis/buildkite branch from e235b2c to ef6313f Mar 14, 2019
@turt2live turt2live requested a review from vector-im/riot-web Mar 14, 2019
@jryans jryans self-requested a review Mar 15, 2019
Copy link
Member

jryans left a comment

Looking reasonable. I think my questions here have already been asked on the other repos, so I'll wait for those replies.

Nit: Buildkite seems to spell their name with lowercase "K".

scripts/fetch-develop.deps.sh Show resolved Hide resolved
@turt2live

This comment has been minimized.

Copy link
Member Author

turt2live commented Mar 15, 2019

Nit: Buildkite seems to spell their name with lowercase "K".

Can I just disagree with their branding and continue using bad habits?

(I'll go around fixing it)

@turt2live turt2live changed the title Use BuildKite for CI Use Buildkite for CI Mar 15, 2019
We should be giving the PR the best possible chance at passing the build.
@turt2live turt2live requested a review from jryans Mar 15, 2019
@jryans
jryans approved these changes Mar 15, 2019
Copy link
Member

jryans left a comment

Great, this one looks good to me! 😁

@turt2live turt2live merged commit 771909e into develop Mar 15, 2019
4 checks passed
4 checks passed
buildkite/riot-web/pr Build #35 passed (3 minutes, 50 seconds)
Details
buildkite/riot-web/pr/eslint-lint Passed (1 minute, 12 seconds)
Details
buildkite/riot-web/pr/karma-tests Passed (3 minutes, 40 seconds)
Details
buildkite/riot-web/pr/pipeline Passed (3 seconds)
Details
@turt2live turt2live deleted the travis/buildkite branch Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.