Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare the officially supported browsers in the README #9177

Merged
merged 3 commits into from Mar 15, 2019

Conversation

@turt2live
Copy link
Member

turt2live commented Mar 14, 2019

Fixes #8701

Please also review matrix-org/matrix-react-sdk#2793

turt2live added a commit to matrix-org/matrix-react-sdk that referenced this pull request Mar 14, 2019
@turt2live turt2live requested a review from vector-im/riot-web Mar 14, 2019
@jryans jryans self-requested a review Mar 15, 2019
@jryans
jryans approved these changes Mar 15, 2019
Copy link
Member

jryans left a comment

Thanks so much for doing this! 🎉

@@ -3,6 +3,9 @@ Riot

Riot (formerly known as Vector) is a Matrix web client built using the [Matrix React SDK](https://github.com/matrix-org/matrix-react-sdk).

Riot is officially supported on the web in modern versions of Chrome, Firefox, and Safari. Other browsers may work, however

This comment has been minimized.

Copy link
@jryans

jryans Mar 15, 2019

Member

Should we clarify that this means the desktop versions of those browsers only, so people don't assume mobile browsers as well? (Is there a way to say that without the antiquated word "desktop"...?)

This comment has been minimized.

Copy link
@turt2live

turt2live Mar 15, 2019

Author Member

I ended up adding words for "please use mobile apps" instead. How does it sound?

@turt2live turt2live requested a review from jryans Mar 15, 2019
@jryans
jryans approved these changes Mar 15, 2019
Copy link
Member

jryans left a comment

Great, this looks good to me. Thanks for adding the mobile wording. 😁

@turt2live turt2live merged commit abb6bee into develop Mar 15, 2019
4 checks passed
4 checks passed
buildkite/riot-web/pr Build #38 passed (4 minutes, 2 seconds)
Details
buildkite/riot-web/pr/eslint-lint Passed (1 minute, 4 seconds)
Details
buildkite/riot-web/pr/karma-tests Passed (3 minutes, 31 seconds)
Details
buildkite/riot-web/pr/pipeline Passed (3 seconds)
Details
@turt2live turt2live deleted the travis/browser-support-docs branch Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.