Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert away from `Promise.defer` #9278

Merged
merged 1 commit into from Mar 26, 2019

Conversation

@jryans
Copy link
Member

jryans commented Mar 26, 2019

Promise.defer is deprecated in Bluebird and it logs loudly each time it's
called. This cleans up testing logs significantly by converting away from it.

`Promise.defer` is deprecated in Bluebird and it logs loudly each time it's
called. This cleans up testing logs significantly by converting away from it.
@jryans jryans requested a review from vector-im/riot-web Mar 26, 2019
@jryans jryans added this to In Review in Workflow Mar 26, 2019
Copy link
Collaborator

t3chguy left a comment

lgtm

@jryans

This comment has been minimized.

Copy link
Member Author

jryans commented Mar 26, 2019

I believe this is safe to merge. CI is being too helpful here... I used the same branch name as one that contains a problem on the React SDK side, so the branch matching brought that failure here.

@jryans jryans merged commit 2e24b0c into vector-im:develop Mar 26, 2019
2 of 4 checks passed
2 of 4 checks passed
buildkite/riot-web/pr Build #83 failed (5 minutes, 58 seconds)
Details
buildkite/riot-web/pr/karma-tests Failed (exit status 1)
Details
buildkite/riot-web/pr/eslint-lint Passed (1 minute, 8 seconds)
Details
buildkite/riot-web/pr/pipeline Passed (4 seconds)
Details
Workflow automation moved this from In Review to In Test Mar 26, 2019
@turt2live turt2live moved this from In Test to Done in Workflow Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.