Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use `on_logged_in` action in tests #9279

Merged
merged 2 commits into from Mar 27, 2019

Conversation

@jryans
Copy link
Member

jryans commented Mar 26, 2019

This changes the way tests wait for login to complete from a timer-based system
(which can cause intermittent failures) to an action-based system. The lifecycle
code dispatches the action on_logged_in when login completes which we can wait
for in the tests as a much better indication that work is done.

Required for matrix-org/matrix-react-sdk#2826
Part of #9271

jryans added 2 commits Mar 26, 2019
This changes the way tests wait for login to complete from a timer-based system
(which can cause intermittent failures) to an action-based system. The lifecycle
code dispatches the action `on_logged_in` when login completes which we can wait
for in the tests as a much better indication that work is done.
@jryans jryans requested a review from vector-im/riot-web Mar 26, 2019
@jryans jryans merged commit e8ec6cc into vector-im:develop Mar 27, 2019
4 checks passed
4 checks passed
buildkite/riot-web/pr Build #85 passed (2 minutes, 51 seconds)
Details
buildkite/riot-web/pr/eslint-lint Passed (1 minute, 38 seconds)
Details
buildkite/riot-web/pr/karma-tests Passed (2 minutes, 38 seconds)
Details
buildkite/riot-web/pr/pipeline Passed (4 seconds)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.