Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure auth footer links through Riot config #9297

Merged
merged 1 commit into from Mar 28, 2019

Conversation

@TheJJ
Copy link
Contributor

TheJJ commented Mar 27, 2019

Our organization needs a imprint and privacy statement right on the login page, and some links to organization pages as well.

I've added a possibility to customize those links through the config.json:

    "branding": {
        # this is already upstream:
        "welcomeBackgroundUrl": "themes/org/bg.jpg",
        "authHeaderLogoUrl": "themes/org/orglogo.svg",

        # these are now added by this pull request:
        "authFooterLinks": [
            {"text": "Our Organization", "url": "https://best-org-ever.edu"},
            {"text": "Some subdepartment", "url": "https://subdepartment.best-org-ever.edu"},
            {"text": "Impressum", "url": "/legal/impressum.html"},
            {"text": "Datenschutz", "url": "/legal/datenschutz.html"},
            {"text": "github", "url": "https://github.com/vector-im/riot-web"}
        ]
    },

Fixes #9127.

@TheJJ TheJJ force-pushed the TheJJ:custom_login_footer_links branch 2 times, most recently from 014af75 to 605ca7f Mar 27, 2019
@jryans jryans self-requested a review Mar 28, 2019
@jryans jryans changed the title configure auth footer links through sdkconfig Configure auth footer links through Riot config Mar 28, 2019
Copy link
Member

jryans left a comment

Thanks for the contribution! It looks reasonable overall, and it addresses something already requested by others. 😁

Please add a line to the config.json section of the README about this new option.

src/components/views/auth/VectorAuthFooter.js Outdated Show resolved Hide resolved
Signed-off-by: Jonas Jelten <jelten@in.tum.de>
@TheJJ TheJJ force-pushed the TheJJ:custom_login_footer_links branch from 605ca7f to 5a05182 Mar 28, 2019
@jryans
jryans approved these changes Mar 28, 2019
Copy link
Member

jryans left a comment

Great, this looks good to me. 😁

@jryans jryans merged commit 01794ae into vector-im:develop Mar 28, 2019
4 checks passed
4 checks passed
buildkite/riot-web/pr Build #93 passed (2 minutes, 48 seconds)
Details
buildkite/riot-web/pr/eslint-lint Passed (1 minute, 10 seconds)
Details
buildkite/riot-web/pr/karma-tests Passed (2 minutes, 43 seconds)
Details
buildkite/riot-web/pr/pipeline Passed (5 seconds)
Details
@TheJJ TheJJ deleted the TheJJ:custom_login_footer_links branch Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.