Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expiration to mobile guide cookie #9383

Merged
merged 3 commits into from Apr 4, 2019

Conversation

@turt2live
Copy link
Member

turt2live commented Apr 4, 2019

See #9360

This is to prevent it from always working. Cookies without an expiration are supposed to expire at the end of the session, however the nature of mobile browsers means that the session is unlikely to ever end.

turt2live added 3 commits Apr 2, 2019
See #9360

This is to prevent it from always working. Cookies without an expiration are supposed to expire at the end of the session, however the nature of mobile browsers means that the session is unlikely to ever end.
We also check for a specific value in case people set it to `true` for some reason.
@turt2live turt2live requested a review from vector-im/riot-web Apr 4, 2019
@turt2live turt2live added this to In Review in Workflow Apr 4, 2019
@turt2live turt2live removed this from In Review in Workflow Apr 4, 2019
@turt2live turt2live added this to In Review in Workflow Apr 4, 2019
@jryans
jryans approved these changes Apr 4, 2019
Copy link
Member

jryans left a comment

Thanks, looks good to me! 😁

@turt2live turt2live merged commit 2aeaa08 into develop Apr 4, 2019
4 checks passed
4 checks passed
buildkite/riot-web Build #114 passed (2 minutes, 52 seconds)
Details
buildkite/riot-web/eslint-lint Passed (1 minute, 11 seconds)
Details
buildkite/riot-web/karma-tests Passed (2 minutes, 43 seconds)
Details
buildkite/riot-web/pipeline Passed (3 seconds)
Details
Workflow automation moved this from In Review to In Test Apr 4, 2019
@turt2live turt2live deleted the travis/expire-mobile-page branch Apr 4, 2019
@turt2live turt2live moved this from In Test to Done in Workflow May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.