Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom profile directory #9408

Merged
merged 1 commit into from Apr 10, 2019

Conversation

@pacien
Copy link
Contributor

pacien commented Apr 9, 2019

A custom user data directory can now be specified using the "profile-dir" command line argument.

This PR solves #6175.

Copy link
Member

turt2live left a comment

Thanks for the PR! Please take a look at our contributing guidelines (which also apply to this project) for things like signoff.

In addition, some documentation on the new argument in the readme would be handy.

@pacien pacien force-pushed the pacien:custom-profiledir branch from faefbd7 to 71e088f Apr 9, 2019
@pacien

This comment has been minimized.

Copy link
Contributor Author

pacien commented Apr 9, 2019

@turt2live Sure, the commit has been amended accordingly.

@turt2live turt2live dismissed their stale review Apr 9, 2019

concerns addressed - sending to the team review queue for code review

@turt2live turt2live requested a review from vector-im/riot-web Apr 9, 2019
@jryans jryans self-requested a review Apr 9, 2019
@jryans jryans added this to In Review in Workflow Apr 9, 2019
Copy link
Member

jryans left a comment

Thanks for adding this! 😁 I actually needed something like this recently, so it definitely seems helpful to have.

electron_app/src/electron-main.js Outdated Show resolved Hide resolved
A custom user data directory can now be specified using the "profile-dir"
command line argument.

Github ref: closes #6175

Signed-off-by: Pacien TRAN-GIRARD <pacien.trangirard@pacien.net>
@pacien pacien force-pushed the pacien:custom-profiledir branch from 71e088f to 2c9b51f Apr 9, 2019
@turt2live turt2live requested a review from jryans Apr 9, 2019
@jryans
jryans approved these changes Apr 10, 2019
Copy link
Member

jryans left a comment

Looks good! 😁 Thanks for the contribution!

@jryans jryans merged commit b3bee52 into vector-im:develop Apr 10, 2019
4 checks passed
4 checks passed
buildkite/riot-web/pr Build #138 passed (2 minutes, 54 seconds)
Details
buildkite/riot-web/pr/eslint-lint Passed (1 minute, 27 seconds)
Details
buildkite/riot-web/pr/karma-tests Passed (2 minutes, 46 seconds)
Details
buildkite/riot-web/pr/pipeline Passed (4 seconds)
Details
Workflow automation moved this from In Review to In Test Apr 10, 2019
@turt2live turt2live moved this from In Test to Done in Workflow May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.