Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update installation instructions with new repo #9500

Merged
merged 4 commits into from Apr 17, 2019

Conversation

@axelsimon
Copy link
Contributor

axelsimon commented Apr 16, 2019

Signed-off-by: axel simon <axelsimon at axelsimon.net>

change mentions of https://riot.im/packages to https://packages.riot.im
add instructions to remove old, now-untrusted riot.im signing key
update language and move from 'apt-get` to the simpler `apt`
@jryans jryans requested a review from vector-im/riot-web Apr 16, 2019
Copy link
Member

dbkr left a comment

otherwise looks great, thanks!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
dbkr and others added 2 commits Apr 16, 2019
better wording

Co-Authored-By: axelsimon <github@axelsimon.net>
README.md Outdated
Releases are signed by PGP, and can be checked against the public key
at https://riot.im/packages/keys/riot.asc .
Releases are signed using gpg and the OpenPGP standard, and can be checked against the public key located
at https://packages.riot.im/debian/riot.im-archive-keyring.asc .

This comment has been minimized.

Copy link
@turt2live

turt2live Apr 16, 2019

Member

This doesn't exist, did you mean riot-im-archive-keyring.asc ? Also someone is going to have to explain to me the difference between that and https://packages.riot.im/riot-release-key.asc

This comment has been minimized.

Copy link
@axelsimon

axelsimon Apr 16, 2019

Author Contributor

Good catch. Thanks.
I really meant https://packages.riot.im/riot-release-key.asc, I'll amend.

This comment has been minimized.

Copy link
@turt2live

turt2live Apr 16, 2019

Member

given that's also Dave's suggestion, I'm inclined to trust that too :D

This comment has been minimized.

Copy link
@axelsimon

axelsimon Apr 16, 2019

Author Contributor

So we've got https://packages.riot.im/riot-release-key.asc for the general package signing and https://packages.riot.im/debian/riot.im-archive-keyring.asc as the key to add to apt's key store, on Debian. Correct?

This comment has been minimized.

Copy link
@turt2live

turt2live Apr 16, 2019

Member

Those sound like the right things to me

This comment has been minimized.

Copy link
@dbkr

dbkr Apr 17, 2019

Member

Yep, that's right - the signing keys are now separate with one the one in /debian for the debian repo and the release key for signing the web release tarballs.

@dbkr dbkr merged commit 2c0504d into vector-im:develop Apr 17, 2019
4 checks passed
4 checks passed
buildkite/riot-web/pr Build #155 passed (5 minutes, 32 seconds)
Details
buildkite/riot-web/pr/eslint-lint Passed (1 minute, 11 seconds)
Details
buildkite/riot-web/pr/karma-tests Passed (3 minutes, 6 seconds)
Details
buildkite/riot-web/pr/pipeline Passed (4 seconds)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.