Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default for --include arg #9517

Merged
merged 1 commit into from Apr 17, 2019

Conversation

@dbkr
Copy link
Member

dbkr commented Apr 17, 2019

nargs options are arrays and we assume it's an array later, so it
would iterate over each char of the string if left as the default

nargs options are arrays and we assume it's an array later, so it
would iterate over each char of the string if left as the default
@dbkr dbkr requested a review from vector-im/riot-web Apr 17, 2019
Copy link
Member

turt2live left a comment

looks like an array

@dbkr dbkr merged commit 597b3e1 into develop Apr 17, 2019
4 checks passed
4 checks passed
buildkite/riot-web Build #158 passed (2 minutes, 52 seconds)
Details
buildkite/riot-web/eslint-lint Passed (1 minute, 11 seconds)
Details
buildkite/riot-web/karma-tests Passed (2 minutes, 39 seconds)
Details
buildkite/riot-web/pipeline Passed (3 seconds)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.