Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package step to buildkite pipeline #9568

Merged
merged 5 commits into from Apr 26, 2019

Conversation

@dbkr
Copy link
Member

dbkr commented Apr 26, 2019

No description provided.

@dbkr dbkr marked this pull request as ready for review Apr 26, 2019
@jryans
jryans approved these changes Apr 26, 2019
Copy link
Member

jryans left a comment

Looks great!

Should we also remove the out-of-file steps that @turt2live had defined directly in https://buildkite.com/matrix-dot-org/riot-web/settings? (They only run for his test branch, so I assume we don't need them anymore...)

- "yarn install"
- "echo '+++ Packaging'"
- "./scripts/ci_package.sh"
#branches: "travis/test-build"

This comment has been minimized.

Copy link
@jryans

jryans Apr 26, 2019

Member

Remove?

This comment has been minimized.

Copy link
@dbkr

dbkr Apr 26, 2019

Author Member

ah, sorry, I thought I got in and changed that to develop before you looked :p

This comment has been minimized.

Copy link
@dbkr

dbkr Apr 26, 2019

Author Member

(and yep, I'll remove the ones travis added)

@dbkr dbkr merged commit ae62a46 into develop Apr 26, 2019
4 checks passed
4 checks passed
buildkite/riot-web/pr Build #190 passed (2 minutes, 50 seconds)
Details
buildkite/riot-web/pr/eslint-lint Passed (1 minute, 23 seconds)
Details
buildkite/riot-web/pr/karma-tests Passed (2 minutes, 43 seconds)
Details
buildkite/riot-web/pr/pipeline Passed (4 seconds)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.