Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail if there's no local config to remove #9571

Merged
merged 1 commit into from Apr 26, 2019

Conversation

@dbkr
Copy link
Member

dbkr commented Apr 26, 2019

The script has a set -e so don't fail if there's nothing to rm

This raises the question of whether we want to be copying config.json from the root to webapp/ at all (which we do in copy-res.js) - I don't think we want it in the general case and for the electron build we can put it straight into webapp/ instead.

Either way I think we want this though.

The script has a set -e so don't fail if there's nothing to rm
@dbkr dbkr requested a review from jryans Apr 26, 2019
@jryans
jryans approved these changes Apr 26, 2019
Copy link
Member

jryans left a comment

Thanks, sorry for the trouble...!

@dbkr dbkr merged commit 03b1914 into develop Apr 26, 2019
4 checks passed
4 checks passed
buildkite/riot-web Build #186 passed (5 minutes, 3 seconds)
Details
buildkite/riot-web/eslint-lint Passed (1 minute, 6 seconds)
Details
buildkite/riot-web/karma-tests Passed (3 minutes, 8 seconds)
Details
buildkite/riot-web/pipeline Passed (8 seconds)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.