Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert redeploy.py to buildkite #9577

Merged
merged 4 commits into from Apr 26, 2019

Conversation

@dbkr
Copy link
Member

dbkr commented Apr 26, 2019

Hopefully fairly self-explanatory

@dbkr dbkr requested a review from vector-im/riot-web Apr 26, 2019
@jryans
jryans approved these changes Apr 26, 2019
Copy link
Member

jryans left a comment

Looks good overall, thanks! 😁

scripts/redeploy.py Outdated Show resolved Hide resolved
scripts/redeploy.py Outdated Show resolved Hide resolved
@@ -2,7 +2,7 @@
#
# auto-deploy script for https://riot.im/develop
#
# Listens for HTTP hits. When it gets one, downloads the artifact from jenkins
# Listens for HTTP hits. When it gets one, downloads the artifact from buildkite

This comment has been minimized.

Copy link
@jryans

jryans Apr 26, 2019

Member

Maybe link to https://buildkite.com/docs/apis/webhooks somewhere in the file.

This comment has been minimized.

Copy link
@dbkr

dbkr Apr 26, 2019

Author Member

done

abort(400, "Missing or bad build number")
if event == 'ping':
print("Got ping request - responding")
return jsonify({'response': 'pong!'})

This comment has been minimized.

Copy link
@jryans

jryans Apr 26, 2019

Member

I guess the response can be anything here?

This comment has been minimized.

Copy link
@dbkr

dbkr Apr 26, 2019

Author Member

yep

jryans and others added 3 commits Apr 26, 2019
Co-Authored-By: dbkr <dbkr@users.noreply.github.com>
Co-Authored-By: dbkr <dbkr@users.noreply.github.com>
@dbkr dbkr merged commit 00d3359 into develop Apr 26, 2019
4 checks passed
4 checks passed
buildkite/riot-web/pr Build #197 passed (5 minutes, 37 seconds)
Details
buildkite/riot-web/pr/eslint-lint Passed (1 minute, 7 seconds)
Details
buildkite/riot-web/pr/karma-tests Passed (2 minutes, 45 seconds)
Details
buildkite/riot-web/pr/pipeline Passed (1 second)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.