Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay creating the `Favico` instance #9616

Merged
merged 1 commit into from May 2, 2019

Conversation

@jryans
Copy link
Member

jryans commented May 2, 2019

This avoids a canvas permission prompt from appearing on page load for users in
Firefox's resist fingerprinting mode. The prompt will still happen once you log
in and receive a notification, but at least this prevents it from happening
during the initial app experience.

Fixes #9605

This avoids a canvas permission prompt from appearing on page load for users in
Firefox's resist fingerprinting mode. The prompt will still happen once you log
in and receive a notification, but at least this prevents it from happening
during the initial app experience.

Fixes #9605
@jryans jryans requested a review from vector-im/riot-web May 2, 2019
Copy link
Contributor

bwindels left a comment

lgtm!

@jryans jryans merged commit 8cb7eee into develop May 2, 2019
4 checks passed
4 checks passed
buildkite/riot-web Build #223 passed (5 minutes, 29 seconds)
Details
buildkite/riot-web/eslint-lint Passed (1 minute, 9 seconds)
Details
buildkite/riot-web/karma-tests Passed (3 minutes, 8 seconds)
Details
buildkite/riot-web/pipeline Passed (3 seconds)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.