Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn upgrade #9626

Merged
merged 1 commit into from May 3, 2019

Conversation

@dbkr
Copy link
Member

dbkr commented May 3, 2019

ALL THE UPDATES!

(so many updates)

ALL THE UPDATES!

(so many updates)
@dbkr dbkr requested a review from vector-im/riot-web May 3, 2019
@jryans jryans requested review from jryans and removed request for vector-im/riot-web May 3, 2019
@jryans
jryans approved these changes May 3, 2019
Copy link
Member

jryans left a comment

Includes an upgrade of Webpack, which seems probably safe, but it does appear to change the minifier to terser, so we should watch out for issues with prod builds.

version "3.0.4"
resolved "https://registry.yarnpkg.com/base-x/-/base-x-3.0.4.tgz#94c1788736da065edb1d68808869e357c977fa77"
integrity sha512-UYOadoSIkEI/VrRGSG6qp93rp2WdokiAiNYDfGW5qURAY8GiAQkvMbwNNSDYiVJopqv4gCna7xqf4rrNGp+5AA==
dependencies:
safe-buffer "^5.0.1"

base-x@^3.0.2:
version "3.0.5"

This comment has been minimized.

Copy link
@jryans

jryans May 3, 2019

Member

Hmm, this also has 2 base-x versions, but over here tests still pass...?

Once the resolutions block merges to JS SDK, maybe try yarn install / yarn upgrade again and see if it avoids this?

This comment has been minimized.

Copy link
@dbkr

dbkr May 3, 2019

Author Member

Hmm - I've yarn installed, upgraded, removed node modules and reinstalled and the lockfile come out the same. Even putting an equivalent resolutions entry in riot-web's package.json doesn't affect it. However I still only have one version of base-x and that is 3.0.4, so looks like it's fine? Either way I think the only alternative would be to hand-edit the file.

This comment has been minimized.

Copy link
@jryans

jryans May 3, 2019

Member

Hmm, curious. I suppose if you've only got one version in practice, then maybe it's okay. Seems fine to defer until we find a reason it's breaking something.

@dbkr dbkr merged commit 0c36849 into develop May 3, 2019
4 checks passed
4 checks passed
buildkite/riot-web Build #239 passed (2 minutes, 42 seconds)
Details
buildkite/riot-web/eslint-lint Passed (1 minute, 9 seconds)
Details
buildkite/riot-web/karma-tests Passed (2 minutes, 36 seconds)
Details
buildkite/riot-web/pipeline Passed (4 seconds)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.