Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify comment on is_url and hs_url handling #9719

Merged
merged 1 commit into from May 16, 2019

Conversation

@turt2live
Copy link
Member

turt2live commented May 14, 2019

Reviewer: Note that this is pointed at the .well-known feature branch, not develop. This is intentional as the feature branch is still unsafe to merge to develop.

We don't actually need to do anything because the app transparently handles this.

See #9290

We don't actually need to do anything because the app transparently handles this.

See #9290
@turt2live turt2live requested a review from vector-im/riot-web May 14, 2019
@turt2live turt2live added this to In Review in Workflow May 14, 2019
@turt2live turt2live removed this from In Review in Workflow May 14, 2019
@turt2live turt2live added this to In Review in Workflow May 14, 2019
@jryans
jryans approved these changes May 16, 2019
Copy link
Member

jryans left a comment

Makes sense to me. 😁

@turt2live turt2live merged commit 51f5671 into travis/feature/wellknown2 May 16, 2019
4 checks passed
4 checks passed
buildkite/riot-web Build #286 passed (5 minutes, 21 seconds)
Details
buildkite/riot-web/eslint-lint Passed (1 minute, 14 seconds)
Details
buildkite/riot-web/karma-tests Passed (3 minutes, 5 seconds)
Details
buildkite/riot-web/pipeline Passed (7 seconds)
Details
Workflow automation moved this from In Review to In Test May 16, 2019
@turt2live turt2live deleted the travis/wk/clarify_is_hs_url branch May 16, 2019
@turt2live turt2live removed this from In Test in Workflow May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.