Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Dockerfile work for develop and other branches #9736

Merged
merged 1 commit into from May 16, 2019

Conversation

@turt2live
Copy link
Member

turt2live commented May 15, 2019

Fixes #9701 (by not timing out, allowing us to use Docker Hub again)
Fixes #9606 (the rules are already set up, we just need to have something to build 馃槃)

We force yarn to use a longer network timeout because Docker Hub's limited machines are not capable of downloading the resources fast enough. The tests I've performed on this branch have not failed due to network timeouts, so the value is presumed high enough.

Note: Docker Hub is slow, our builds easily take 20-40 minutes to complete.

Otherwise we run into problems where Docker Hub's limited machines timeout trying to download our dependencies
@turt2live turt2live force-pushed the travis/docker-test branch from 0abff6d to 3123b42 May 15, 2019
@turt2live turt2live marked this pull request as ready for review May 15, 2019
@turt2live turt2live requested a review from vector-im/riot-web May 15, 2019
@jryans
jryans approved these changes May 16, 2019
Copy link
Member

jryans left a comment

Seems reasonable, let's try it. It still seems worth changing to using pre-built packages like Dave mentioned though, right? Or is there a reason we want Docker to build from source?

@turt2live

This comment has been minimized.

Copy link
Member Author

turt2live commented May 16, 2019

I'm desperately trying to avoid having secrets anywhere in this whole build, so building from source is ideal. Getting artifacts from buildkite is near impossible and a nightmare (comically, Jenkins makes it as easy as a single curl)

@turt2live turt2live merged commit 6f8c6bf into develop May 16, 2019
4 checks passed
4 checks passed
buildkite/riot-web/pr Build #314 passed (2 minutes, 46 seconds)
Details
buildkite/riot-web/pr/eslint-lint Passed (1 minute, 3 seconds)
Details
buildkite/riot-web/pr/karma-tests Passed (2 minutes, 36 seconds)
Details
buildkite/riot-web/pr/pipeline Passed (3 seconds)
Details
@turt2live turt2live deleted the travis/docker-test branch May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.