Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base Docker image on nginx:alpine, not the larger nginx:latest #9848

Merged
merged 1 commit into from May 27, 2019

Conversation

@spantaleev
Copy link
Contributor

spantaleev commented May 27, 2019

nginx:latest is based on Debian Stretch and is listed as being 45MB,
while nginx:alpine is based on Alpine 3.9 and is just 7MB.

Basing the riot-web Docker image on nginx:alpine should
make it 38MB smaller compared to the current situation.

The nginx version seems to be "latest mainline" on both (currently 1.15.12),
judging by each Dockerfile:

Signed-off-by: Slavi Pantaleev slavi@devture.com

`nginx:latest` is based on Debian Stretch and is listed as being 45MB,
while `nginx:alpine` is based on Alpine 3.9 and is just 7MB.

Basing the riot-web Docker image on `nginx:alpine` should
make it 38MB smaller compared to the current situation.

The nginx version seems to be "latest mainline" on both (currently 1.15.12),
judging by each Dockerfile:
- https://github.com/nginxinc/docker-nginx/blob/e5123eea0d29c8d13df17d782f15679458ff899e/mainline/stretch/Dockerfile
- https://github.com/nginxinc/docker-nginx/blob/e5123eea0d29c8d13df17d782f15679458ff899e/mainline/alpine/Dockerfile
@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented May 27, 2019

So the reason this wasn't done originally is that the Alpine image was causing problems with file permissions post-build in my testing. Will need to test it all again to see if it's magically fixed.

@turt2live turt2live self-requested a review May 27, 2019
Copy link
Member

turt2live left a comment

Looks like whatever the problem was has gone away - so merging

@turt2live turt2live merged commit 982416b into vector-im:develop May 27, 2019
@turt2live turt2live added this to In Test in Workflow May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.