Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Twemoji loading on Windows dev machines #9869

Merged
merged 1 commit into from May 28, 2019

Conversation

@jryans
Copy link
Member

jryans commented May 28, 2019

This corrects our path handling on Windows development machines for
paths referenced in JS and HTML files. Both images and fonts (like
Twemoji) were afflicted (with Windows-style backslash path delimiters),
but browsers seems to tolerate them in the src attribute of images, so
we didn't notice that variant before.

This corrects our path handling on Windows development machines for
paths referenced in JS and HTML files. Both images and fonts (like
Twemoji) were afflicted (with Windows-style backslash path delimiters),
but browsers seems to tolerate them in the `src` attribute of images, so
we didn't notice that variant before.
@jryans jryans requested a review from turt2live May 28, 2019
@jryans jryans added this to In Review in Workflow May 28, 2019
Copy link
Member

turt2live left a comment

image

@jryans jryans merged commit 53d8341 into develop May 28, 2019
4 checks passed
4 checks passed
buildkite/riot-web Build #385 passed (3 minutes, 12 seconds)
Details
buildkite/riot-web/eslint-lint Passed (1 minute, 5 seconds)
Details
buildkite/riot-web/karma-tests Passed (3 minutes, 6 seconds)
Details
buildkite/riot-web/pipeline Passed (5 seconds)
Details
Workflow automation moved this from In Review to In Test May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.