Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the user's pre-existing HS when config validation fails #9892

Merged
merged 3 commits into from May 31, 2019

Conversation

@turt2live
Copy link
Member

turt2live commented May 29, 2019

Requires matrix-org/matrix-react-sdk#3043
Fixes #9835
This is a temporary measure for #9828

Only applies if the user appears to be logged in. If the user is not logged in, we scream loudly.

A note on the messaging: The errors being displayed to users come from deep within the js-sdk, which is not easily translated. Instead of trying to wrestle a homeserver URL into the error, I've just stuck a sentence into the error box to hopefully make it clear that it's not the user's fault.

image
Pretend that says "Homeserver URL does not appear to be a valid homeserver" instead of "Unexpected error"

Only applies if the user appears to be logged in. If the user is not logged in, we scream loudly.

This is a temporary measure for #9828

Fixes #9835
@turt2live turt2live added this to In Progress in Workflow May 29, 2019
@turt2live turt2live removed this from In Progress in Workflow May 30, 2019
@turt2live turt2live requested a review from vector-im/riot-web May 30, 2019
@bwindels bwindels requested review from bwindels and removed request for vector-im/riot-web May 31, 2019
Copy link
Contributor

bwindels left a comment

Not showing this to logged-in user is a good improvement! Thanks!

src/vector/index.js Outdated Show resolved Hide resolved
@turt2live turt2live merged commit 1459bfe into develop May 31, 2019
4 checks passed
4 checks passed
buildkite/riot-web/pr Build #412 passed (5 minutes, 45 seconds)
Details
buildkite/riot-web/pr/eslint-lint Passed (54 seconds)
Details
buildkite/riot-web/pr/karma-tests Passed (2 minutes, 53 seconds)
Details
buildkite/riot-web/pr/pipeline Passed (6 seconds)
Details
@turt2live turt2live deleted the travis/check-login-for-config branch May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.