Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add settingDefaults to sample config #9919

Merged
merged 2 commits into from Oct 7, 2019

Conversation

@bwindels
Copy link
Contributor

bwindels commented May 31, 2019

@bwindels bwindels requested a review from vector-im/riot-web Oct 1, 2019
Copy link
Member

turt2live left a comment

Would be nice to add to the docs for what this is, but otherwise looks fine to me. It's a bit awkward that it's empty - can we stick something like breadcrumbs into this?

@bwindels bwindels force-pushed the bwindels/settings-config-doc branch 2 times, most recently from 726e9f8 to 259ca06 Oct 7, 2019
@bwindels

This comment has been minimized.

Copy link
Contributor Author

bwindels commented Oct 7, 2019

Would be nice to add to the docs for what this is, but otherwise looks fine to me. It's a bit awkward that it's empty - can we stick something like breadcrumbs into this?

Added breadcrumbs as example, and should already be documented at https://github.com/vector-im/riot-web/blob/develop/docs/config.md

@bwindels bwindels merged commit 57e597e into develop Oct 7, 2019
4 checks passed
4 checks passed
buildkite/riot-web/pr Build #1060 passed (3 minutes, 7 seconds)
Details
buildkite/riot-web/pr/eslint-lint Passed (36 seconds)
Details
buildkite/riot-web/pr/karma-tests Passed (3 minutes, 2 seconds)
Details
buildkite/riot-web/pr/pipeline Passed (3 seconds)
Details
@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented Oct 7, 2019

ah, so it is - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.