Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for defaultCountryCode #9927

Merged
merged 1 commit into from Jun 1, 2019

Conversation

@turt2live
Copy link
Member

turt2live commented Jun 1, 2019

@turt2live turt2live requested a review from vector-im/riot-web Jun 1, 2019
@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Jun 1, 2019

lgtm, but shouldn’t we be pulling this from the Accept headers?

@turt2live

This comment has been minimized.

Copy link
Member Author

turt2live commented Jun 1, 2019

The user's language was a bit unreliable in my testing. Stuff like "en" showing up without a country.

@turt2live turt2live merged commit 29eeb1e into develop Jun 1, 2019
4 checks passed
4 checks passed
buildkite/riot-web Build #416 passed (5 minutes, 18 seconds)
Details
buildkite/riot-web/eslint-lint Passed (56 seconds)
Details
buildkite/riot-web/karma-tests Passed (2 minutes, 52 seconds)
Details
buildkite/riot-web/pipeline Passed (6 seconds)
Details
@turt2live turt2live deleted the travis/default-country-code branch Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.