Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fail on server liveliness checks during startup #9960

Merged
merged 3 commits into from Jun 7, 2019

Conversation

@turt2live
Copy link
Member

turt2live commented Jun 5, 2019

Also warn about deprecated config option usage.

See matrix-org/matrix-react-sdk#3067

Also warn about deprecated config option usage.

See #9828
turt2live added 2 commits Jun 5, 2019
@turt2live turt2live removed the in progress label Jun 5, 2019
@turt2live turt2live requested a review from vector-im/riot-web Jun 5, 2019
@dbkr
dbkr approved these changes Jun 6, 2019
console.warn(
"DEPRECATED CONFIG OPTION: In the future, default_hs_url will not be accepted. Please use " +
"default_server_config instead.",
);

This comment has been minimized.

Copy link
@dbkr

dbkr Jun 6, 2019

Member

I would be OK with keeping this as a shorthand, but fine either way.

This comment has been minimized.

Copy link
@turt2live

turt2live Jun 6, 2019

Author Member

I'm of similar thinking, although also wanting to keep the ways of configuring a homeserver to a minimum. I've hopefully worded the docs to say "it's deprecated, but less deprecated than default_*_url"

@turt2live turt2live merged commit f5e5ad9 into develop Jun 7, 2019
4 checks passed
4 checks passed
buildkite/riot-web/pr Build #440 passed (3 minutes, 1 second)
Details
buildkite/riot-web/pr/eslint-lint Passed (55 seconds)
Details
buildkite/riot-web/pr/karma-tests Passed (2 minutes, 53 seconds)
Details
buildkite/riot-web/pr/pipeline Passed (3 seconds)
Details
@turt2live turt2live deleted the travis/fail-fast-but-not-too-fast branch Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.