Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KitKat support #405

Open
BillCarsonFr opened this issue Jul 19, 2019 · 5 comments

Comments

@BillCarsonFr
Copy link
Member

commented Jul 19, 2019

RiotX no longer launches on KitKat.

OkHttp has drop support for tls<=1.1, and will throw a runtime exception on android <5
OkHttp has created a branch that still support outdated versions, this branch will get maintained for critical issues until dec 31, 2020
https://medium.com/square-corner-blog/okhttp-3-13-requires-android-5-818bb78d07ce

Also, riotX uses drawables with attributes (redacted messages, reaction) that will crash

@BillCarsonFr BillCarsonFr added the crash label Jul 19, 2019

@bmarty bmarty added this to the sprint2 milestone Jul 19, 2019

@bmarty

This comment has been minimized.

Copy link
Member

commented Jul 19, 2019

We may consider to support only API 21+ as it represents currently 99% of the number of installations of the current Riot (not X) installation.
For the sake of security and also to simplified developement (ex: by allowing usage of attribute in drawables)

Also: https://twitter.com/minsdkversion :)

@z3ntu

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2019

What I've put into #94 worked for me back in March on a 4.4 device.

@MayeulC

This comment has been minimized.

Copy link

commented Jul 24, 2019

We may consider to support only API 21+ as it represents currently 99% of the number of installations of the current Riot (not X) installation.

That might be due to a catch-22. I know I haven't pushed some kitkat users to Matrix because I was finding the Riot Android too poor for them. The kitkat marketshare might be bigger in the less-tech-savvy that Riot hasn't reached yet. Well, that's an hypothesis, but I don't see that specific reason as being a valid one.

@deepbluev7

This comment has been minimized.

Copy link

commented Jul 28, 2019

I would prefer it, if Android 4.4 support could be restored for now, as SailfishOS and its Android emulation only supports 4.4 (aside from the XA2 releases, which are out of beta since only about a week). There are multiple projects implementing matrix clients for Sailfish, but they are not quite ready yet, so RiotX support for at least the next year or so would be preferable.

(The Android emulation on Sailfish supports TLS1.2 since the latest update)

@ressit

This comment has been minimized.

Copy link

commented Aug 3, 2019

Thanks that Riot was fixed to run again on Android 4.4, please do not consider to replace it with an app with which you and I can't communicate anymore.
The number of installations will increase over time, number of supported platforms and hasslefree
operation.
Concering TSL1.2 support in kitkat, the issue seems to be partly addressable
https://blog.dev-area.net/2015/08/13/android-4-1-enable-tls-1-1-and-tls-1-2/
https://medium.com/tech-quizlet/working-with-tls-1-2-on-android-4-4-and-lower-f4f5205629a

@bmarty bmarty modified the milestones: sprint2, sprint3 Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.