Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/aggregation p1 wrapup #168

Merged
merged 19 commits into from Jun 7, 2019

Conversation

Projects
None yet
2 participants
@BillCarsonFr
Copy link
Member

commented Jun 7, 2019

Stabilization PR for reaction phase 1

  • Use emoji compatibility fallback for quick reactions, reactions pills, and reaction history
  • Bug fixes on reactions (missing reactions, delay in local echo)
  • Show simple reaction history (long click on existing reaction or via context menu)

image

  • Better support for big numbers in reactions

image

  • Use bigger font for short messages with only emojis

image

  • Added copy permalink action in menu

  • Added context menu for more items (membership, states)

image

Fixes issues with read receipt on invisible events (edits)
Fixes #113

@ganfra

ganfra approved these changes Jun 7, 2019

Copy link
Collaborator

left a comment

Just 2 remarks, but otherwise good work :)

@@ -55,7 +55,8 @@ class RoomDetailViewModel(initialState: RoomDetailViewState,
private val roomId = initialState.roomId
private val eventId = initialState.eventId
private val displayedEventsObservable = BehaviorRelay.create<RoomDetailActions.EventDisplayed>()
private val timeline = room.createTimeline(eventId, TimelineDisplayableEvents.DISPLAYABLE_TYPES)
private val timeline = room.createTimeline(eventId,

This comment has been minimized.

Copy link
@ganfra

ganfra Jun 7, 2019

Collaborator

Just split this in a variable please

This comment has been minimized.

Copy link
@BillCarsonFr

BillCarsonFr Jun 7, 2019

Author Member

done

messageBodyTextView.text = it.messageBody
messageTimestampText.text = it.ts

GlideApp.with(this).clear(senderAvatarImageView)

This comment has been minimized.

Copy link
@ganfra

ganfra Jun 7, 2019

Collaborator

Why not using AvatarRenderer for the whole stuff?

This comment has been minimized.

Copy link
@BillCarsonFr

BillCarsonFr Jun 7, 2019

Author Member

yes, thx

@BillCarsonFr BillCarsonFr force-pushed the feature/aggregation_p1_wrapup branch from ac9cee8 to 5f34e58 Jun 7, 2019

Valere added some commits Jun 7, 2019

Valere
Valere

@BillCarsonFr BillCarsonFr merged commit 8f2c005 into develop Jun 7, 2019

0 of 3 checks passed

buildkite/riotx-android Build #152 started
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@bmarty bmarty deleted the feature/aggregation_p1_wrapup branch Jun 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.