Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(logplex source): Add instrumentation #3356

Merged
merged 1 commit into from Aug 9, 2020
Merged

Conversation

ktff
Copy link
Contributor

@ktff ktff commented Aug 5, 2020

Closes #3202

Open questions

Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com>
@ktff ktff added type: enhancement A value-adding code change that enhances its existing functionality. domain: observability Anything related to monitoring/observing Vector source: logplex labels Aug 5, 2020
@ktff ktff requested a review from lukesteensen August 5, 2020 14:14
@ktff ktff self-assigned this Aug 5, 2020
@binarylogic
Copy link
Contributor

Thanks @ktff. I assume #2660 will fix this issue when it's complete?

@ktff
Copy link
Contributor Author

ktff commented Aug 7, 2020

I assume #2660 will fix this issue when it's complete?

@binarylogic Yes, but trace context would need to be main source of truth. So it's fine to leave this as it is?

@binarylogic
Copy link
Contributor

For now it should be fine. Once #2660 is fine we’ll come back and update.

@ktff ktff merged commit 6bac9f1 into master Aug 9, 2020
@ktff ktff deleted the ktff/logplex_inst branch August 9, 2020 16:14
mengesb pushed a commit to jacobbraaten/vector that referenced this pull request Dec 9, 2020
Signed-off-by: Kruno Tomola Fabro <krunotf@gmail.com>
Signed-off-by: Brian Menges <brian.menges@anaplan.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: observability Anything related to monitoring/observing Vector type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define events for the heroku_logplex source
3 participants