enhancement(logplex source): Add instrumentation #3356
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3202
Open questions
HerokuLogplexEventReceived
we would count one event twice since enhancement(observability): Add internal events forhttp
source #3264 addedHTTPEventsReceived
to a shared code thatlogplex
source uses.To fix this, I propose moving
emit!(HTTPEventsReceived)
from here https://github.com/timberio/vector/blob/547c8ad6ac6ad4fa21dbf3a70f6b18570704bed6/src/sources/util/http.rs#L90-L93 to here https://github.com/timberio/vector/blob/547c8ad6ac6ad4fa21dbf3a70f6b18570704bed6/src/sources/http.rs#L58 And also removing this label https://github.com/timberio/vector/blob/547c8ad6ac6ad4fa21dbf3a70f6b18570704bed6/src/internal_events/http.rs#L51 so to make it clear these errors are aggregated from multiple types of sources.ref. Document internal instrumentation rules #3247 (comment) (Edit. Include internal trace context with internal metrics #2660 will solve this)