Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement(remap): Add to_syslog_severity function for Syslog log level keywords #5505

Merged
merged 16 commits into from Dec 22, 2020
Merged

enhancement(remap): Add to_syslog_severity function for Syslog log level keywords #5505

merged 16 commits into from Dec 22, 2020

Conversation

lucperkins
Copy link
Contributor

@lucperkins lucperkins commented Dec 11, 2020 •
edited

Addresses #5501 with a to_syslog_severity Remap function that converts a Syslog log level keyword into an integer severity level.

Note: the heavy lifting has been done here. I'm marking this as a draft until (a) #5522 lands and (b) we figure out a naming system for modules/namespaces.

@lucperkins lucperkins changed the title enhancement(remap): Add to_severity function enhancement(remap): Add to_severity function for Syslog log level keywords Dec 11, 2020
@JeanMertz JeanMertz mentioned this pull request Mar 28, 2023
Open
jszwedko
jszwedko reviewed Dec 14, 2020
View reviewed changes
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should call this to_syslog_severity? This would be more specific and leave the door open for other severity mappings.

@jszwedko
Copy link
Member

jszwedko commented Dec 14, 2020 •
edited by JeanMertz

https://github.com/timberio/vector/issues/5507 seems related which proposes calling this syslog::to_severity.

@lucperkins lucperkins marked this pull request as draft December 15, 2020 17:09
Luc Perkins added 7 commits December 19, 2020 18:33
Add to_severity function for Remap
1d53092 
Signed-off-by: Luc Perkins <luc@timber.io>
Fix syntax issue and add CUE docs
89aebc7 
Signed-off-by: Luc Perkins <luc@timber.io>
Fix CUE formatting
5e13ea8 
Signed-off-by: Luc Perkins <luc@timber.io>
Fix array issue in tests
1741f44 
Signed-off-by: Luc Perkins <luc@timber.io>
Fix broken tests
537c2b9 
Signed-off-by: Luc Perkins <luc@timber.io>
Fix broken tests
22ed0b5 
Signed-off-by: Luc Perkins <luc@timber.io>
Rebase, and add type definition tests
71a334d 
Signed-off-by: Luc Perkins <luc@timber.io>
Fix struct name copy/paste issue
a6e31f3 
Signed-off-by: Luc Perkins <luc@timber.io>
jszwedko
jszwedko reviewed Dec 21, 2020
View reviewed changes
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In absence of #5507, which feels like it might be a little ways off, I'd propose calling this to_syslog_severity. We can always deprecate it and change to syslog::to_severity later.

Otherwise, this looks good to me!

jszwedko
jszwedko approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few last notes, otherwise this looks good.

docs/reference/remap/to_syslog_severity.cue Outdated Show resolved Hide resolved
lib/remap-functions/src/to_syslog_severity.rs Outdated Show resolved Hide resolved
lib/remap-functions/src/to_syslog_severity.rs Show resolved Hide resolved
lib/remap-functions/src/to_syslog_severity.rs Outdated Show resolved Hide resolved
Luc Perkins added 3 commits December 21, 2020 10:14
Update Cargo.toml to include function
2021033 
Signed-off-by: Luc Perkins <luc@timber.io>
Use Error::from instead of Error::Call
ff56349 
Signed-off-by: Luc Perkins <luc@timber.io>
Update function name in identifier method
c865458 
Signed-off-by: Luc Perkins <luc@timber.io>
Luc Perkins added 2 commits December 21, 2020 10:14
Fix docs
dfd01b6 
Signed-off-by: Luc Perkins <luc@timber.io>
Fix alphabetization formatting issue
35b6e1e 
Signed-off-by: Luc Perkins <luc@timber.io>
@lucperkins lucperkins changed the title enhancement(remap): Add to_severity function for Syslog log level keywords enhancement(remap): Add to_syslog_severity function for Syslog log level keywords Dec 21, 2020
@lucperkins lucperkins marked this pull request as ready for review December 21, 2020 19:30
@lucperkins lucperkins mentioned this pull request Dec 21, 2020
Closed
Fix merge conflict
e81e20c 
Signed-off-by: Luc Perkins <luc@timber.io>
@lucperkins lucperkins merged commit b38ce3d into master Dec 22, 2020
@lucperkins lucperkins deleted the remap-to-severity-func branch December 22, 2020 00:54
This was referenced Jan 9, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jszwedko jszwedko jszwedko approved these changes

@JeanMertz JeanMertz Awaiting requested review from JeanMertz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lucperkins @jszwedko