fix(influxdb_metrics sink): Fix formatting of timestamps in tests #7036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruce Guenter <bruce.guenter@datadoghq.com>
bruceg
added
type: bug
bruceg
requested review from
a team,
StephenWakely and
jszwedko
and removed request for
a team and
StephenWakely
|
Kicked off integration tests: https://github.com/timberio/vector/actions/runs/726783899 |
|
@bruceg it looks like maybe this broke the prometheus tests? https://github.com/timberio/vector/runs/2289716169?check_suite_focus=true |
Signed-off-by: Bruce Guenter <bruce.guenter@datadoghq.com>
|
👍 kicked off new run: https://github.com/timberio/vector/actions/runs/726873636 |
|
@bruceg integration tests look good. |
jszwedko
added a commit
that referenced
this pull request
May 11, 2021
Part of #6330 This adds an `unnest` function to facilitate turning one event that has a field with an array into an array of events. See documentation examples. This is slightly different than the proposed implementation in #7036, but I think it results in a straightforward and easy to understand transformation that works regardless of what type the array elements are. The proposed implementation would have required them to be objects to be able to merge into the parent object. Merging the child element into the parent, if desired, will be possible by stringing together another remap transform that would effectively do `subfield = del(.subfield); . |= subfield`. Or presumably via iteration / mapping when we get to that. Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
StephenWakely
pushed a commit
that referenced
this pull request
Jul 7, 2021
Part of #6330 This adds an `unnest` function to facilitate turning one event that has a field with an array into an array of events. See documentation examples. This is slightly different than the proposed implementation in #7036, but I think it results in a straightforward and easy to understand transformation that works regardless of what type the array elements are. The proposed implementation would have required them to be objects to be able to merge into the parent object. Merging the child element into the parent, if desired, will be possible by stringing together another remap transform that would effectively do `subfield = del(.subfield); . |= subfield`. Or presumably via iteration / mapping when we get to that. Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
StephenWakely
pushed a commit
that referenced
this pull request
Jul 9, 2021
Part of #6330 This adds an `unnest` function to facilitate turning one event that has a field with an array into an array of events. See documentation examples. This is slightly different than the proposed implementation in #7036, but I think it results in a straightforward and easy to understand transformation that works regardless of what type the array elements are. The proposed implementation would have required them to be objects to be able to merge into the parent object. Merging the child element into the parent, if desired, will be possible by stringing together another remap transform that would effectively do `subfield = del(.subfield); . |= subfield`. Or presumably via iteration / mapping when we get to that. Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
StephenWakely
pushed a commit
that referenced
this pull request
Jul 11, 2021
Part of #6330 This adds an `unnest` function to facilitate turning one event that has a field with an array into an array of events. See documentation examples. This is slightly different than the proposed implementation in #7036, but I think it results in a straightforward and easy to understand transformation that works regardless of what type the array elements are. The proposed implementation would have required them to be objects to be able to merge into the parent object. Merging the child element into the parent, if desired, will be possible by stringing together another remap transform that would effectively do `subfield = del(.subfield); . |= subfield`. Or presumably via iteration / mapping when we get to that. Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
jszwedko
added a commit
that referenced
this pull request
Jul 12, 2021
* enhancement(remap): Add unnest function Part of #6330 This adds an `unnest` function to facilitate turning one event that has a field with an array into an array of events. See documentation examples. This is slightly different than the proposed implementation in #7036, but I think it results in a straightforward and easy to understand transformation that works regardless of what type the array elements are. The proposed implementation would have required them to be objects to be able to merge into the parent object. Merging the child element into the parent, if desired, will be possible by stringing together another remap transform that would effectively do `subfield = del(.subfield); . |= subfield`. Or presumably via iteration / mapping when we get to that. Signed-off-by: Jesse Szwedko <jesse@szwedko.me> * function argument is path Signed-off-by: Jesse Szwedko <jesse@szwedko.me> * Add documentation link Signed-off-by: Jesse Szwedko <jesse@szwedko.me> * Added more comprehensive typedef Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Revert accidentally committed change Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Change to use as_segments Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Fixed final test case Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Feedback from Spencer Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Implemented feedback from Jean Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Fix typedefs for variables Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Unnest is infallible Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Moved tests to unnest Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Expose types from type_def Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Add timezone Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Fix links Signed-off-by: Jesse Szwedko <jesse@szwedko.me> Co-authored-by: Stephen Wakely <fungus.humungus@gmail.com>
lucperkins
pushed a commit
that referenced
this pull request
Jul 19, 2021
* enhancement(remap): Add unnest function Part of #6330 This adds an `unnest` function to facilitate turning one event that has a field with an array into an array of events. See documentation examples. This is slightly different than the proposed implementation in #7036, but I think it results in a straightforward and easy to understand transformation that works regardless of what type the array elements are. The proposed implementation would have required them to be objects to be able to merge into the parent object. Merging the child element into the parent, if desired, will be possible by stringing together another remap transform that would effectively do `subfield = del(.subfield); . |= subfield`. Or presumably via iteration / mapping when we get to that. Signed-off-by: Jesse Szwedko <jesse@szwedko.me> * function argument is path Signed-off-by: Jesse Szwedko <jesse@szwedko.me> * Add documentation link Signed-off-by: Jesse Szwedko <jesse@szwedko.me> * Added more comprehensive typedef Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Revert accidentally committed change Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Change to use as_segments Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Fixed final test case Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Feedback from Spencer Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Implemented feedback from Jean Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Fix typedefs for variables Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Unnest is infallible Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Moved tests to unnest Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Expose types from type_def Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Add timezone Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Fix links Signed-off-by: Jesse Szwedko <jesse@szwedko.me> Co-authored-by: Stephen Wakely <fungus.humungus@gmail.com> Signed-off-by: Luc Perkins <luc.perkins@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bruce Guenter bruce.guenter@datadoghq.com