chore: Use a forked version of leveldb-sys #7522
Conversation
There was a problem hiding this comment.
Nice, thank you!
I unarchived https://github.com/timberio/leveldb-sys and made sure everyone has access. I think you should be able to switch it over there if you like.
This changed Cargo.lock much more than I anticipated. Did you mean to upgrade all of those packages? The Tokio 1.6 upgrade #7477 is currently blocked on a test failure (which I also see on this PR).
The forked version of leveldb-sys patched in here limits leveldb to a maximum of 10 mmap'ed LDB files, reducing the total memory burden of vector. Upstream leveldb will map 1000 files, so there's quite a difference in memory usage. Unfortunately this 10 is not configurable. At the moment the fork is under my personal Github account. I think we ought to fork to timberio -- we have an archived version -- and pin the patch to a SHA. I don't have enough juice in the Github org to achieve this. Resolves #7514 Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
Signed-off-by: Brian L. Troutwine <brian@troutwine.us>
I ended up needing to run Now that you mention it, let me see if I can't avoid running |
|
@jszwedko ah, hmm. No dice. When adding the patch I am forced to run |
|
I think you could just do |
Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
D'oh |
The forked version of leveldb-sys patched in here limits leveldb to a maximum of
10 mmap'ed LDB files, reducing the total memory burden of vector. Upstream
leveldb will map 1000 files, so there's quite a difference in memory
usage. Unfortunately this 10 is not configurable.
At the moment the fork is under my personal Github account. I think we ought to
fork to timberio -- we have an archived version -- and pin the patch to a SHA. I
don't have enough juice in the Github org to achieve this.
Resolves #7514
Signed-off-by: Brian L. Troutwine brian@troutwine.us