enhancement(aws_s3 source): Send content_md5 when writing objects #7936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required when the bucket has [object locking](https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-lock.html) enabled, but also gives a bit more confidence that the object makes it to S3 uncorrupted. Unfortunately the test I added doesn't actually validate that Vector works with object locked buckets due to [a gap in localstack](localstack/localstack#4166) but I did verify it manually be creating a bucket with object locking enabled, observing the failure, making the implementation change, and observing the success. Closes: #7310 Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
Signed-off-by: Jesse Szwedko <jesse@szwedko.me>
jszwedko
commented
Jun 18, 2021
| #[tokio::test] | ||
| async fn s3_insert_message_into() { | ||
| let cx = SinkContext::new_test(); | ||
|
|
||
| let config = config(1000000).await; | ||
| let bucket = uuid::Uuid::new_v4().to_string(); |
There was a problem hiding this comment.
I refactored these tests a bit to always create a new bucket to avoid any pollution and separate the config creation from the bucket creation.
spencergilbert
approved these changes
Jun 21, 2021
The only thing I can think of is if it reduced performance, but it seems to be negligible. Using their benches: I believe the HTTP requests will far outweigh the additional cost introduced here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required when the bucket has object
locking
enabled, but also gives a bit more confidence that the object makes it
to S3 uncorrupted.
Unfortunately the test I added doesn't actually validate that Vector
works with object locked buckets due to a gap in
localstack but
I did verify it manually be creating a bucket with object locking
enabled, observing the failure, making the implementation change, and
observing the success.
Closes: #7310
Signed-off-by: Jesse Szwedko jesse@szwedko.me