Fixes for IE8, new options, methods #16

Merged
merged 1 commit into from Apr 30, 2012

Conversation

Projects
None yet
2 participants
Contributor

alexblack commented Apr 12, 2012

Hi, proper.js is awesome, nice work!

  1. I hit a few problems testing in IE8, .map and .filter are not native methods, so I modified the code to use map and filter from underscore.js.
  2. I added an option called startEmpty, because I wanted the activate the control so that the placeholder text showed up, and the tools, but not to set focus.
  3. I added a method called contentStripped, which returns the stripped version of the content, so it can be validated for length for example.

I hope you can accept this pull request, let me know!

thx

  • Alex
Contributor

alexblack commented Apr 12, 2012

Oh, I also removed the << symbols around the placeholder, not sure if you want that. I figured this way the user could decide whether or not they wanted those symbols wrapped around the placeholder - I didn't.

@michael michael pushed a commit that referenced this pull request Apr 30, 2012

Michael Aufreiter Merge pull request #16 from alexblack/master
Fixes for IE8, new options, methods
ee26a62

@michael michael merged commit ee26a62 into vectorsize:master Apr 30, 2012

Contributor

michael commented Apr 30, 2012

Merged in. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment