Skip to content

feat: add pokeapi card#23

Merged
vedangj044 merged 2 commits intovedangj044:mainfrom
tq-bit:main
Oct 1, 2021
Merged

feat: add pokeapi card#23
vedangj044 merged 2 commits intovedangj044:mainfrom
tq-bit:main

Conversation

@tq-bit
Copy link
Contributor

@tq-bit tq-bit commented Oct 1, 2021

Description

Please include the details of the API used in this PR.

  • Pokeapi provides a variety of entries on pokemon and allows you to query them.
  • This PR includes local storage to comply with the fair-use policy.

You can find the docs here: https://pokeapi.co/docs/v2

Screenshot

image


Checklist
  • API used in this PR was not used in just-calling-random-api before.
  • API used in this PR is Public or I have permission to use it.
  • My contribution is working.
  • My contribution doesn't expose any API keys.
  • My changes don't generate any new warnings.
  • My changes don't affect any work done by other developers.

To tick a box, replace [ ] with [x].

@vedangj044
Copy link
Owner

This is a really nice PR, good work with the local storage. Keep rocking!

@vedangj044 vedangj044 merged commit a30d18a into vedangj044:main Oct 1, 2021
@tq-bit
Copy link
Contributor Author

tq-bit commented Oct 1, 2021

Hey, cool, thank you for merging & the feedback.

Wanted to say - this was my first open-source pr. Most likely not the last one.

Thank you for providing the opportunity 🥇

@vedangj044
Copy link
Owner

Haha, in sometime open source would become a moral thing for you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants