COMMITDOCK-0014: Security, CI, and maintainability pass#10
Merged
Conversation
Hardens stash listing (directory validation, NUL and length limits, capped lines, execFile without shell, windowsHide) and tightens webview protocol parsing (stash index cap, path length and NUL rejection). Wraps the webview message handler in try/catch so unexpected failures surface in the UI and logs. Adds npm run typecheck with DOM lib in tsconfig, fixes webview timer and API narrowing for strict checking, and strengthens ESLint (eqeqeq, no-throw-literal). CI and release workflows run typecheck; CI uses npm ci; Marketplace publish uses the repo-pinned vsce from the lockfile. Refreshes devDependencies (codicons, esbuild, vsce) and documents security assumptions in the README. Releases as 0.9.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardens stash listing (directory validation, NUL and length limits, capped lines, execFile without shell, windowsHide) and tightens webview protocol parsing (stash index cap, path length and NUL rejection). Wraps the webview message handler in try/catch so unexpected failures surface in the UI and logs. Adds npm run typecheck with DOM lib in tsconfig, fixes webview timer and API narrowing for strict checking, and strengthens ESLint (eqeqeq, no-throw-literal). CI and release workflows run typecheck; CI uses npm ci; Marketplace publish uses the repo-pinned vsce from the lockfile. Refreshes devDependencies (codicons, esbuild, vsce) and documents security assumptions in the README. Releases as 0.9.2.