John of Spintend request to add Ubox family HW config files#502
Merged
vedderb merged 5 commits intovedderb:masterfrom May 31, 2022
Merged
John of Spintend request to add Ubox family HW config files#502vedderb merged 5 commits intovedderb:masterfrom
vedderb merged 5 commits intovedderb:masterfrom
Conversation
JohnSpintend added Ubox files
Delete no_limits files
Restore make file parallel disable
Clear package and build directory
Contributor
Author
|
There is a "hw_ubox_single" files exits in the hw_conf/other/, it was committed by one of our users, Tharon Rivera, thanks for him. I will ask his opinion for either to merge this file into ubox directory or keep it alone. |
Owner
|
Looks good to me! If the file hw_ubox_single is the same as one of the versions you added it is probably best to remove it and only keep your files. Since you make and test the hardware it is best if you manage and test your configurations. |
Contributor
Author
|
Thank you!
李正杰
***@***.***
…------------------ 原始邮件 ------------------
发件人: "Benjamin ***@***.***>;
发送时间: 2022年6月1日(星期三) 凌晨3:32
收件人: ***@***.***>;
抄送: ***@***.***>; ***@***.***>;
主题: Re: [vedderb/bldc] John of Spintend request to add Ubox family HW config files (PR #502)
Merged #502 into master.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Contributor
Author
|
Thank you Ben, I'm waiting Tharon Rivera's reply.
李正杰
***@***.***
…------------------ 原始邮件 ------------------
发件人: "Benjamin ***@***.***>;
发送时间: 2022年6月1日(星期三) 凌晨3:32
收件人: ***@***.***>;
抄送: ***@***.***>; ***@***.***>;
主题: Re: [vedderb/bldc] John of Spintend request to add Ubox family HW config files (PR #502)
Looks good to me!
If the file hw_ubox_single is the same as one of the versions you added it is probably best to remove it and only keep your files. Since you make and test the hardware it is best if you manage and test your configurations.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This is John, from Spintend. We have been making VESC compatible hardware since 2020. Due to the lack of manpower, and not familiar with github, we have not requested to join the official firmware list. This is my first attempt to submit. If there are any errors or questions, please let me know.
Thank you!