Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiplayer desync with ONLY Rampant mod enabled, 5 seconds after joining the server for any player #37

Closed
grumd opened this issue Feb 17, 2021 · 22 comments

Comments

@grumd
Copy link

grumd commented Feb 17, 2021

Save: _autosave4.zip
mod-settings.dat (zipped): mod-settings.zip
Rampant 1.0.1 and nothing else enabled on the server.
Factorio 1.1.21 stable.

Desync doesn't happen on the same save if I just disable Rampant.

Desync report:
desync-report-2021-02-17_20-41-37.zip

Really wanted to try this awesome mod with my friends in a multiplayer game but it's not playable, desyncs instantly when joining the game :(

If you need any information or help to reproduce the issue, please just ask me.

I could do a small donation if you don't feel like supporting this mod for free.

@veden
Copy link
Owner

veden commented Feb 18, 2021

The next patch has a couple of desync fixes coming.

It may be a week or more before it gets published though.

@grumd
Copy link
Author

grumd commented Feb 18, 2021

I see, thanks for replying!

@veden
Copy link
Owner

veden commented Feb 27, 2021

Should be fixed in 1.0.3

@grumd
Copy link
Author

grumd commented Feb 28, 2021

Just updated to 1.0.4, seems to work fine! Thank you. I'll report back when I get to play a full session with friends too.

@grumd
Copy link
Author

grumd commented Mar 1, 2021

@veden Worked fine for quite some time with 1.0.4, but encountered another desync after playing for an hour or so. Got it to reproduce on a save only using Rampant.

desync report: https://puu.sh/HlgKm/38b308035e.zip
save: _autosave9.zip
mod-settings.dat: mod-settings.zip

Any player can enter the server with this save, only Rampant 1.0.4 enabled, Factorio was 1.1.21, and after a minute or two of doing nothing you'll get desynced.

@grumd
Copy link
Author

grumd commented Mar 10, 2021

@veden I beg you my man :D Sorry to bother anyway, but have you tried reproducing with that save yet?

@veden
Copy link
Owner

veden commented Mar 10, 2021

Yes, I was able to get a desync to happen.

Haven't had time to determine how to fix it.

@grumd
Copy link
Author

grumd commented Mar 10, 2021

@veden Alright, thanks! Keep me updated please <3

@veden
Copy link
Owner

veden commented Mar 13, 2021

Rampant_1.0.5.zip
A copy of the mod that has all the hooks disabled that allow Rampant to interact with the game.
Still desyncs at ~7861188 with your autosave9.
The mod version turns the game speed up to 7 until tick 7861000 then it turns the speed to 0.5

I don't think this is a Rampant thing to fix. The sub-forum for desyncs with mods doesn't seem to allow new topics, so currently this is a dead end for me.

@grumd
Copy link
Author

grumd commented Mar 14, 2021

Do you think this wouldn't be an issue if the save was started with Rampant enabled? I only added this mod later into the game. Or maybe if I regenerated all the terrain and biters it would help?

How different is this 1.0.5 version from the base version? You said you disabled all the hooks, but I'm not sure how this affects gameplay, which features does this remove?

@veden
Copy link
Owner

veden commented Mar 14, 2021

No, when you added Rampant wouldn't matter.

My guess is that it has something to do with Hives and spawning non-unit entities, but I'm guessing and don't really have any idea.

That 1.0.5 pretty much has the control.lua disabled in that Rampant wont make unit groups, move them, upgrade or build bases, change AI states and/or process the pheromone map.

Literally the only thing that 1.0.5 does is the prototype changes for things like new enemies otherwise the logic is completely disabled.

The purpose is to narrow down what is causing the desync, but as far as I can tell, I disabled the lua parts that could desync within Rampant and the desync still happens.

Just to be clear, that 1.0.5 build is a debugging build and it removes 99% of Rampant features and the desync still happens.

@veden
Copy link
Owner

veden commented Mar 14, 2021

My only thought currently is to try without the new enemies on 1.0.4.

@bghira
Copy link

bghira commented Apr 22, 2021

you have to report the thread to moderators with the request to move to desyncs with mods forum.

@axaluss
Copy link

axaluss commented May 8, 2021

What's up with the desyncs? Were they located and fixed?

@SneakyB
Copy link

SneakyB commented Jun 2, 2021

Hello,
is there any info about strange desyncs? I have the same problem after killing all monsters it is working quite well, but after some time and evolution desync happend - strange is that 1 player dont have this problem and 2 players got it all the time, we tested with only rampart(newest version) and still happend for now it makes our server unplayable with mod.

@veden
Copy link
Owner

veden commented Dec 6, 2021

another attempt at fixing the desyncs is on master branch

@veden
Copy link
Owner

veden commented Dec 14, 2021

2.0.0 was released yesterday with a potential desync fix.
Please let me know if you are still having desyncs.

@PlexPt
Copy link
Contributor

PlexPt commented Feb 6, 2022

local variables will not saved to saves, so avoid to use local

@veden
Copy link
Owner

veden commented Mar 30, 2022

do you have a location that local variables are being used that needs to be corrected?

@PlexPt
Copy link
Contributor

PlexPt commented Mar 30, 2022

@veden
Copy link
Owner

veden commented Mar 30, 2022

I meant in the code. I've read the tutorial before.

@veden
Copy link
Owner

veden commented May 9, 2022

3.1.0 should have a desync fix, please let me know if you are still having problems

@veden veden closed this as completed Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants