Fix backwards absorb/recoil in MoveMeta #67

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Owner

encukou commented Feb 11, 2012

MoveMeta.recoil was negative on recoil moves, but positive on draining moves. Switch that around.

Owner

eevee commented Mar 25, 2012

The games store this the same way; it's how much the user's health gets modified. Maybe the column name should be changed, instead (though I can't imagine what to)?

Owner

magical commented Mar 26, 2012

Maybe the column name should be changed, instead (though I can't imagine what to)?

Easy, MoveMeta.absorb.

Owner

encukou commented Mar 26, 2012

Or drain?

Owner

eevee commented Mar 28, 2012

Ooh. I love drain.

Negative drain then becomes, obviously, nega-drain.

@encukou encukou Fix drain/recoil name in MoveMeta
The column was named recoil, but positive values meant
drain.
Rename the column, and introduce a hybrid property for
recoil.
3e8fa1b
Owner

encukou commented Mar 30, 2012

Let's make it drain, then.

Owner

magical commented Jul 9, 2014

Rebased and pushed

magical closed this Jul 9, 2014

encukou deleted the encukou:absorb-recoil branch Jul 9, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment