Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Description of the problem this pull request fixes
Changes proposed in this pull request:
- sorting feature to allows users to sort based on rows in the DataTable.
** If submitting code for review: **
This PR includes:
Steps to functionally test this:
Aug 16, 2016
1 check was pending
Hi @mattwchun, great work overall! I would take a look at bf80429 to see the ways in which I iterated on and refined your work. In particular, I extracted any hardcoded strings that were reused in multiple places into a standalone
I also simplified the code path in the
Finally, some stylistic changes -- e.g., preferring a more concise store shape (
Hope that helps guide your future PRs! Let me know if you have any questions. Great work overall!