Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Get data object from Config service by reference, not deep clone #108
Previously, any call to
Altering the Config service to return the data object by reference, rather than as a deep clone, reduces the processing needed to the extent that it no longer even shows up on the profiler:
The total run time of
Because the data should be consistent across all charts, and it is just the chart configuration that will vary on a plot-by-plot basis, passing the data by reference improves both the memory usage and the performance of the data load process.
If a specific issue can be identified I'd like to prioritize taking a look at that, since this is a big time saver when loading large data. If nothing is identified my inclination is to merge this and revisit it later if something does turn up, but I don't want to do that without your go-ahead because that attitude may be a bit too cavalier :)