Cleaner schema

[domoritz]

Needs vega/ts-json-schema-generator#19

@jakevdp, before I merge this, can you check that this schema in this PR works for you and doesn't have unused definitions.

[jakevdp]

This got most of them, but there are still a handful of unneeded definitions:

{'BoxPlotConfig',
 'BoxPlotConfigMixins',
 'DataFormatType',
 'FacetedCompositeUnitSpecAlias'}

[domoritz]

Hmm, the boxplot defs are there because we use @hide. I have to check where FacetedCompositeUnitSpecAlias comes from.

[domoritz]

DataFormatType is subtle. The issue is that we are extending an abstract interface but in the extensions, we override the type. I figured out a way to remove it, though.

[domoritz]

There is a bug in the schema generator that causes some other classes to be included.

external.ts

export interface CC {
    c: number;
}

export interface C extends CC {
}

// or: export type C = CC;

test.ts

import { C } from "./external";

export interface MyObject extends C {
    foo: number;
}

[domoritz]

I figured out everything except for FacetedCompositeUnitSpecAlias.

[kanitw]

Need input from @arvind about selection test changes

[kanitw]

Why is type removed from here?

[kanitw]

Please make sure that the type displayed in the table in data.md is correct.

[domoritz]

Because we override it in all cases anyway. I fixed the table in data.md.

[kanitw]

Why are these get removed? We will need input from @arvind if removing these make sense.

[arvind]

I’m guessing these were removed because they are actually not valid Vega-Lite statements. I just had them here to verify that we did the right thing (eg ignore or throw errors as appropriate) if a user specified them. Will go through the other selection test changes too and comment if something looks amiss.

[domoritz]

And now the typescript compiler is smart enough to notice.

[arvind]

Changes to selection tests LGTM.

[domoritz]

@jakevdp Let us know if the schema is clean now. @kanitw feel free to merge when you think it's ready.

[kanitw]

Do you want to wait for @jakevdp's input? If not, feel free to merge.

[domoritz]

The schema is clean except for FacetedCompositeUnitSpecAlias but I can't figure out where that's coming from right now.

[jakevdp]

Thanks!