Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve conflict between scale.domain and bin.extent #3675

Merged
merged 5 commits into from
Apr 28, 2018

Conversation

yhoonkim
Copy link
Contributor

@yhoonkim yhoonkim commented Apr 27, 2018

Fix #3575

  • If scale.domain is specified, use scale.domain despite bin.
  • If scale.domain is specified, axis' ticks are ranged over scale.domain instead of the signal of the bin.extent.
  • If bin.extent is specified, the scale domain is bin.extent by default.

@yhoonkim yhoonkim requested a review from kanitw April 27, 2018 23:30
@yhoonkim yhoonkim changed the title Resolve conflict between scale.domain and bin.extent [WIP]Resolve conflict between scale.domain and bin.extent Apr 28, 2018
@yhoonkim yhoonkim changed the title [WIP]Resolve conflict between scale.domain and bin.extent Resolve conflict between scale.domain and bin.extent Apr 28, 2018
@kanitw kanitw merged commit cf83e03 into master Apr 28, 2018
@kanitw
Copy link
Member

kanitw commented Apr 28, 2018

Thanks so much @yhoonkim!

@kanitw kanitw deleted the yh/bin-extent-domain branch April 28, 2018 04:41
kanitw added a commit that referenced this pull request May 6, 2018
* master:
  docs: fix "example gallery" link in layering docs
  Update versions
  Bump to 2.4.2
  Allow making line uses original order in the data
  Upgrade deps
  Never automatically set scale `zero` to true when custom domain is provided
  Add oz to list of libs in docs (#3690)
  Update and simplify CO2 example
  Rebuild examples
  Add example with missing subobject. Add more tests to formatparse. Always access flattened fields after transforms.
  leave -> leaf
  Only add parse for non-nested fields. Always flatten nested fields.
  Restructure Gallery (#3679)
  Fix typo
  Update details about value vs mark properties
  Remove mocha scripts from CONTRIBUTING.md and add test:inspect script (#3674)
  Resolve conflict between scale.domain and bin.extent (#3675)
  Add datum to access path. Fixes #3441
  Flatten nested fields. Fixes #3369

# Conflicts:
#	_data/examples.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants