Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create correct Tukey boxplot #4573

Merged
merged 3 commits into from Feb 23, 2019
Merged

Create correct Tukey boxplot #4573

merged 3 commits into from Feb 23, 2019

Conversation

kanitw
Copy link
Member

@kanitw kanitw commented Feb 23, 2019

Fix #4568

@kanitw kanitw marked this pull request as ready for review Feb 23, 2019
@kanitw kanitw requested review from chanwutk and domoritz Feb 23, 2019
@kanitw
Copy link
Member Author

@kanitw kanitw commented Feb 23, 2019

For min-max boxplot, we show 5 summary (and groupbys) for the tooltip of both whisker and box.

image

However, for Tukey boxplot, we can’t access “upper/lower whisker” values for the box as they require a different dataflow for filtering, and it’s not worth joining just for the tooltip. I currently show upper/lower whisker for the whisker

image

and 5 summaries for the box

image

The question is should we show min/max in the tooltip for the box of the Tukey box plot?

(Unlike min-max boxplot that visualize min/max with just the whiskers, the Tukey boxplot represents the min/max using either the outlier points or the whisker if there is no outlier on each end.)

@domoritz
Copy link
Member

@domoritz domoritz commented Feb 23, 2019

The behavior you describe sounds good to me.

@kanitw kanitw merged commit 08d951d into master Feb 23, 2019
4 of 5 checks passed
@kanitw kanitw deleted the kw/box-tukey branch Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants