Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent <p> injection for select and/or #4614

Merged
merged 1 commit into from Feb 27, 2019

Conversation

Projects
None yet
2 participants
@clemens-tolboom
Copy link
Contributor

clemens-tolboom commented Feb 27, 2019

https://vega.github.io/vega-lite/docs/selection.html#conditional-encodings has a broken select dropdown.

Please:

  • Make your pull request atomic, fixing one issue at a time unless there are multiple relevant issues that would not make sense in isolation. For the latter case, please make atomic commits so we can easily review each issue.
    • Please add new commit(s) when addressing comments, so we can see easily the new changeset (instead of the whole changeset).
  • Provide a test case & update the documentation under site/docs/
  • Make lint and test pass. (Run yarn test. If your change affects Vega outputs of some examples, re-run yarn build and run yarn build:example EXAMPLE_NAME to re-compile a specific example or yarn build:examples to re-compile all examples.)
  • Rebase onto the latest master branch.
  • Provide a concise title that we can copy to our release note.
    • Use imperative mood and present tense.
    • Mention relevant issues. (e.g., #1)
  • Look at the whole changeset as if you're a reviewer yourself. This will help us focus on catching issues that you might not notice yourself. (For a work-in-progress PR, you can add "[WIP]" prefix to the PR's title. When the PR is ready, you can then remove "[WIP]" and add a comment to notify us.)

Pro-Tip: https://medium.com/@greenberg/writing-pull-requests-your-coworkers-might-enjoy-reading-9d0307e93da3 is a nice article about writing a nice pull request.

@domoritz domoritz merged commit 2ead70d into vega:master Feb 27, 2019

3 checks passed

codecov/patch Coverage not affected when comparing 66c3e73...049d3b9
Details
codecov/project 96.19% remains the same compared to 66c3e73
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@domoritz

This comment has been minimized.

Copy link
Member

domoritz commented Feb 27, 2019

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.