Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress warnings if the spec is composition #154

Merged
merged 1 commit into from
Feb 5, 2018
Merged

Suppress warnings if the spec is composition #154

merged 1 commit into from
Feb 5, 2018

Conversation

sirahd
Copy link
Contributor

@sirahd sirahd commented Feb 4, 2018

@sirahd sirahd requested a review from domoritz February 4, 2018 01:02
@domoritz
Copy link
Member

domoritz commented Feb 4, 2018

This can't be the real fix as it prevents warnings for any concatenated spec. What's your plan for fixing this eventually?

@sirahd
Copy link
Contributor Author

sirahd commented Feb 4, 2018 •
edited
Loading

Here are the solutions I could think of:

  1. There has to be a way to tell which field was used to facet, concat or layer
  2. Vega-scenegraph would have to return the data for the composite field as well (right now it only returns the data of each mark in the plot, but not the field that was used as a composition)

@domoritz domoritz merged commit 52183ee into master Feb 5, 2018
@domoritz domoritz deleted the sh/suppresswarning branch February 5, 2018 18:04
@sirahd sirahd mentioned this pull request Feb 5, 2018
Closed
@github-actions
Copy link

🚀 PR was released in v0.27.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domoritz domoritz Awaiting requested review from domoritz

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sirahd @domoritz