New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align view API example with Embed example and improve DX #1011

Merged
merged 2 commits into from Sep 29, 2017

Conversation

Projects
None yet
2 participants
@clemens-tolboom
Contributor

clemens-tolboom commented Sep 13, 2017

I had a hard time using the view API example. Let's just make it copy / paste proof.

I failed in using

d3.json('https://vega.github.io/vega/examples/bar-chart.vg.json', render);

ReferenceError: d3 is not defined

Not sure how that happened as I'm not loading core only.

clemens-tolboom and others added some commits Sep 13, 2017

Align view API example with Embed example.
I had a hard time using the view API example. Let's just make it copy / paste proof.

I failed in using

```js
d3.json('https://vega.github.io/vega/examples/bar-chart.vg.json', render);
```

> ReferenceError: d3 is not defined

Not sure how that happened as I'm not loading core only.

@jheer jheer merged commit e9db985 into vega:master Sep 29, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@clemens-tolboom

This comment has been minimized.

Show comment
Hide comment
@clemens-tolboom

clemens-tolboom Sep 30, 2017

Contributor

Thanks for the updated version. Awesome!

Contributor

clemens-tolboom commented Sep 30, 2017

Thanks for the updated version. Awesome!

@clemens-tolboom clemens-tolboom deleted the clemens-tolboom:patch-1 branch Sep 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment