Skip to content

/ vegan

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avgdist silently drops observations #246

Closed
jarioksa opened this issue Aug 13, 2017 · 2 comments
Closed

avgdist silently drops observations #246

jarioksa opened this issue Aug 13, 2017 · 2 comments
Labels
request-for-comments

Comments

@jarioksa
Copy link
Contributor

@jarioksa jarioksa commented Aug 13, 2017

Function avgdist will silently drop observations (rows) from the data. This can lead into mysterious mismatches with supplementary data sets. The minimum is to warn on dropping of data. The vegan standard is not to drop data, and the underlying rrarefy function does not drop observations. NB @Microbiology .
@jarioksa jarioksa changed the title avgist silently drops observations avgdist silently drops observations Aug 13, 2017
@Microbiology
Copy link
Contributor

@Microbiology Microbiology commented Aug 15, 2017

Thanks for making this @jarioksa. Sorry, I know we had talked about it before but it fell through the cracks. I'll be able to take care of this sometime in the next couple of days.
@Microbiology Microbiology mentioned this issue Sep 5, 2017
Merged
@jarioksa
Copy link
Contributor Author

@jarioksa jarioksa commented Sep 16, 2017

Closed with PR #251 (commit 2bcd09e).
@jarioksa jarioksa closed this Sep 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
request-for-comments
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@jarioksa @Microbiology
You can’t perform that action at this time.