New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for UDP stats #11

Merged
merged 2 commits into from Jun 6, 2017

Conversation

Projects
None yet
2 participants
@catwell
Copy link
Contributor

catwell commented May 28, 2017

As requested in #10 I tried my hand at implementing UDP support.

It appears to work on my machine, at least it gives me the information I wanted which was SO_REUSEADDR and SO_REUSEPORT.

I noticed a small display issue where long IPV6 addresses can break the layout, but it also exists for TCP and I am not sure increasing the width of the address fields by a lot is a good idea.

@veithen

This comment has been minimized.

Copy link
Owner

veithen commented May 29, 2017

Note that SO_KEEPALIVE is only meaningful for TCP, so this should be moved out of sock_common_options_show.

Remove SO_KEEPALIVE from common options.
SO_KEEPALIVE does not make sense for UDP.

#11 (comment)
@catwell

This comment has been minimized.

Copy link
Contributor Author

catwell commented Jun 5, 2017

Done.

@veithen veithen merged commit 609cb30 into veithen:master Jun 6, 2017

@veithen

This comment has been minimized.

Copy link
Owner

veithen commented Jun 6, 2017

Thanks for your contribution.

@catwell catwell deleted the catwell:pr-udp-1 branch Jun 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment