From 68ab371ab456c037f6ee8836061bb6e60e64fe9e Mon Sep 17 00:00:00 2001 From: Daniel Velazco Date: Tue, 2 Jul 2013 17:27:45 -0700 Subject: [PATCH] Add TODO and cleanup --- TODO | 4 ++++ .../fbwrapper/activity/BaseFacebookWebViewActivity.java | 2 +- .../danvelazco/fbwrapper/webview/FacebookWebChromeClient.java | 4 ++++ Tinfoil-for-Facebook/src/main/res/values/colors.xml | 1 + 4 files changed, 10 insertions(+), 1 deletion(-) create mode 100644 TODO diff --git a/TODO b/TODO new file mode 100644 index 0000000..ca379a3 --- /dev/null +++ b/TODO @@ -0,0 +1,4 @@ +Auto scroll (forced) when coming back using scroll percentages? + + + diff --git a/Tinfoil-for-Facebook/src/main/java/com/danvelazco/fbwrapper/activity/BaseFacebookWebViewActivity.java b/Tinfoil-for-Facebook/src/main/java/com/danvelazco/fbwrapper/activity/BaseFacebookWebViewActivity.java index d4a197c..65e7c0b 100644 --- a/Tinfoil-for-Facebook/src/main/java/com/danvelazco/fbwrapper/activity/BaseFacebookWebViewActivity.java +++ b/Tinfoil-for-Facebook/src/main/java/com/danvelazco/fbwrapper/activity/BaseFacebookWebViewActivity.java @@ -169,7 +169,7 @@ public void onResume() { registerReceiver(mConnectivityReceiver, new IntentFilter(ConnectivityManager.CONNECTIVITY_ACTION)); - // TODO: fix this, this is a horrible lifecycle hack... + // Horrible lifecycle hack if (mCreatingActivity) { mCreatingActivity = false; return; diff --git a/Tinfoil-for-Facebook/src/main/java/com/danvelazco/fbwrapper/webview/FacebookWebChromeClient.java b/Tinfoil-for-Facebook/src/main/java/com/danvelazco/fbwrapper/webview/FacebookWebChromeClient.java index 99ac36a..6376958 100644 --- a/Tinfoil-for-Facebook/src/main/java/com/danvelazco/fbwrapper/webview/FacebookWebChromeClient.java +++ b/Tinfoil-for-Facebook/src/main/java/com/danvelazco/fbwrapper/webview/FacebookWebChromeClient.java @@ -178,6 +178,10 @@ public void onShowCustomView(View view, CustomViewCallback callback) { */ @Override public void onHideCustomView() { + + // [TODO][BUG]: video player won't close sometimes, only toggle media controls + // [TODO][BUG]: sound from video will keep playing sometimes + if (mCustomViewCallback != null) { // Fire the callback mCustomViewCallback.onCustomViewHidden(); diff --git a/Tinfoil-for-Facebook/src/main/res/values/colors.xml b/Tinfoil-for-Facebook/src/main/res/values/colors.xml index 4f7188e..c583af1 100644 --- a/Tinfoil-for-Facebook/src/main/res/values/colors.xml +++ b/Tinfoil-for-Facebook/src/main/res/values/colors.xml @@ -16,6 +16,7 @@ --> + #33b5e5 #cdcdcd #ededed #dddddd